| commit | cc8adbbb64bc098299bb96fb6eabfc97a87792e6 | [log] [tgz] |
|---|---|---|
| author | Marcel Offermans <marrs@apache.org> | Wed Feb 17 10:20:11 2010 +0000 |
| committer | Marcel Offermans <marrs@apache.org> | Wed Feb 17 10:20:11 2010 +0000 |
| tree | 3f5d1fb848ca1a73dfc79d90cd58f0300426974c | |
| parent | b425286c2879ccd0d30a0dfcf56b014493426d36 [diff] |
only log an error if there is no implementation set AND creating an instance using a factory did not work git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@910896 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/dependencymanager/core/src/main/java/org/apache/felix/dm/impl/ServiceImpl.java b/dependencymanager/core/src/main/java/org/apache/felix/dm/impl/ServiceImpl.java index fb617ec..0422fc7 100644 --- a/dependencymanager/core/src/main/java/org/apache/felix/dm/impl/ServiceImpl.java +++ b/dependencymanager/core/src/main/java/org/apache/felix/dm/impl/ServiceImpl.java
@@ -690,10 +690,10 @@ } } } - if (m_implementation == null) { - m_logger.log(Logger.LOG_ERROR, "Implementation cannot be null."); - } if (m_serviceInstance == null) { + if (m_implementation == null) { + m_logger.log(Logger.LOG_ERROR, "Implementation cannot be null."); + } m_serviceInstance = m_implementation; } }