commit 883819eca3d146f9aaae87b5630dd1e46d61a085
author Carsten Ziegeler <cziegeler@apache.org> Tue Jul 03 09:58:43 2012 +0000
committer Carsten Ziegeler <cziegeler@apache.org> Tue Jul 03 09:58:43 2012 +0000
tree 5f6594461bdbe2049b45a823585012fcd5eee3ba
parent 1aeff342f4b997b74df4ce80e96e01fea520b0f5

FELIX-3550 : Reimplement the SCR Generator

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1356652 13f79535-47bb-0310-9956-ffa450edef68

scrplugin/generator/src/main/java/org/apache/felix/scrplugin/xml/ComponentDescriptorIO.java

diff --git a/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/xml/ComponentDescriptorIO.java b/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/xml/ComponentDescriptorIO.java
index 7d280d7..4bb2b44 100644
--- a/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/xml/ComponentDescriptorIO.java
+++ b/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/xml/ComponentDescriptorIO.java
@@ -60,6 +60,8 @@
  */
 public class ComponentDescriptorIO {
 
+    private static final String PROPERTY_ATTR_TYPE = "type";
+
     /** General attribute for the name (component, reference, property) */
     private static final String ATTR_NAME = "name";
 
@@ -126,6 +128,8 @@
 
     private static final String PROPERTY_ATTR_VALUE = "value";
 
+    private static final String PROPERTY_ATTR_PRIVATE = "private";
+
     private static final String REFERENCE = "reference";
 
     private static final String REFERENCE_QNAME = REFERENCE;
@@ -142,12 +146,16 @@
 
     private static final String REFERENCE_ATTR_TARGET = "target";
 
+    private static final String REFERENCE_ATTR_STRATEGY = "strategy";
+
     private static final String INTERFACE = "provide";
 
     private static final String INTERFACE_QNAME = INTERFACE;
 
     private static final String INTERFACE_ATTR_NAME = "interface";
 
+    private static final String PROPERTIES = "properties";
+
     public static List<ClassDescription> read(final InputStream file,
                     final ClassLoader classLoader,
                     final IssueLog iLog, final String location) throws SCRDescriptorException {
@@ -338,7 +346,7 @@
         final AttributesImpl ai = new AttributesImpl();
         IOUtils.addAttribute(ai, ATTR_NAME, property.getName());
         if ( property.getType() != PropertyType.String ) {
-            IOUtils.addAttribute(ai, "type", property.getType());
+            IOUtils.addAttribute(ai, PROPERTY_ATTR_TYPE, property.getType());
         }
         IOUtils.addAttribute(ai, PROPERTY_ATTR_VALUE, property.getValue());
 
@@ -541,7 +549,7 @@
                         final PropertyDescription prop = new PropertyDescription(null);
 
                         prop.setName(propName);
-                        final String type = attributes.getValue("type");
+                        final String type = attributes.getValue(PROPERTY_ATTR_TYPE);
                         if ( type != null ) {
                             try {
                                 prop.setType(PropertyType.valueOf(type));
@@ -575,13 +583,13 @@
                                 prop.setUnbounded(PropertyUnbounded.VECTOR);
                             }
                         }
-                        final String pValue = attributes.getValue("private");
+                        final String pValue = attributes.getValue(PROPERTY_ATTR_PRIVATE);
                         if (pValue != null) {
                             prop.setPrivate(Boolean.valueOf(pValue));
                         }
                     }
 
-                } else if (localName.equals("properties")) {
+                } else if (localName.equals(PROPERTIES)) {
 
                     // TODO: implement the properties tag
 
@@ -638,7 +646,7 @@
                         ref.setUnbind(attributes.getValue(REFERENCE_ATTR_UPDATED));
                     }
 
-                    final String strategy = attributes.getValue("strategy");
+                    final String strategy = attributes.getValue(REFERENCE_ATTR_STRATEGY);
                     if ( strategy != null ) {
                         try {
                             ref.setStrategy(ReferenceStrategy.valueOf(strategy.toUpperCase()));