commit 52a3ab4f25409c56567c9ebc1a1fdc714feb64f5
author Richard S. Hall <rickhall@apache.org> Wed Dec 22 20:48:03 2010 +0000
committer Richard S. Hall <rickhall@apache.org> Wed Dec 22 20:48:03 2010 +0000
tree 746c09e6eb75b71ec7b6f3ae8b558069cbf60f1b
parent 46a0a1b428bf7e555efdc3245a6130f08842f51e

Add configuration property to control bundle cache locking. (FELIX-2700)


git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1052063 13f79535-47bb-0310-9956-ffa450edef68

framework/src/main/java/org/apache/felix/framework/cache/BundleCache.java

diff --git a/framework/src/main/java/org/apache/felix/framework/cache/BundleCache.java b/framework/src/main/java/org/apache/felix/framework/cache/BundleCache.java
index 67687d2..b67c757 100644
--- a/framework/src/main/java/org/apache/felix/framework/cache/BundleCache.java
+++ b/framework/src/main/java/org/apache/felix/framework/cache/BundleCache.java
@@ -68,6 +68,7 @@
 {
     public static final String CACHE_BUFSIZE_PROP = "felix.cache.bufsize";
     public static final String CACHE_ROOTDIR_PROP = "felix.cache.rootdir";
+    public static final String CACHE_LOCKING_PROP = "felix.cache.locking";
     // TODO: CACHE - Remove this once we migrate the cache format.
     public static final String CACHE_SINGLEBUNDLEFILE_PROP = "felix.cache.singlebundlefile";
 
@@ -102,44 +103,52 @@
             }
         }
 
-        File lockFile = new File(cacheDir, CACHE_LOCK_NAME);
-        FileChannel fc = null;
-        FileOutputStream fos = null;
-        try
+        Object locking = m_configMap.get(CACHE_LOCKING_PROP);
+        locking = (locking == null) ? "true" : locking.toString();
+        if (Boolean.parseBoolean((String) locking))
         {
-            if (!getSecureAction().fileExists(lockFile))
-            {
-                fos = getSecureAction().getFileOutputStream(lockFile);
-                fc = fos.getChannel();
-            }
-            else
-            {
-                fos = getSecureAction().getFileOutputStream(lockFile);
-                fc = fos.getChannel();
-            }
-        }
-        catch (Exception ex)
-        {
+            File lockFile = new File(cacheDir, CACHE_LOCK_NAME);
+            FileChannel fc = null;
+            FileOutputStream fos = null;
             try
             {
-                if (fos != null) fos.close();
-                if (fc != null) fc.close();
+                if (!getSecureAction().fileExists(lockFile))
+                {
+                    fos = getSecureAction().getFileOutputStream(lockFile);
+                    fc = fos.getChannel();
+                }
+                else
+                {
+                    fos = getSecureAction().getFileOutputStream(lockFile);
+                    fc = fos.getChannel();
+                }
             }
-            catch (Exception ex2)
+            catch (Exception ex)
             {
-                // Ignore.
+                try
+                {
+                    if (fos != null) fos.close();
+                    if (fc != null) fc.close();
+                }
+                catch (Exception ex2)
+                {
+                    // Ignore.
+                }
+                throw new Exception("Unable to create bundle cache lock file: " + ex);
             }
-            throw new Exception("Unable to create bundle cache lock file: " + ex);
+            try
+            {
+                m_lock = fc.tryLock();
+            }
+            catch (Exception ex)
+            {
+                throw new Exception("Unable to lock bundle cache: " + ex);
+            }
         }
-        try
+        else
         {
-            m_lock = fc.tryLock();
+            m_lock = null;
         }
-        catch (Exception ex)
-        {
-            throw new Exception("Unable to lock bundle cache: " + ex);
-        }
-
     }
 
     public synchronized void release()