commit 23c636ad0c180c74970461a6f891af6ea3e871f3
author Felix Meschberger <fmeschbe@apache.org> Sun May 31 08:31:49 2009 +0000
committer Felix Meschberger <fmeschbe@apache.org> Sun May 31 08:31:49 2009 +0000
tree 80f31355d0b6a7a3230a87bb2b93e13dc09be64a
parent 6d60e6e8e3874d51367325e6f585a09f16c70512

FELIX-1191 Add logging to OBR support plugin

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@780384 13f79535-47bb-0310-9956-ffa450edef68

webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/AbstractObrPlugin.java

diff --git a/webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/AbstractObrPlugin.java b/webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/AbstractObrPlugin.java
index 103ee72..6cf16fa 100644
--- a/webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/AbstractObrPlugin.java
+++ b/webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/AbstractObrPlugin.java
@@ -20,6 +20,7 @@
 
 
 import org.apache.felix.webconsole.internal.BaseManagementPlugin;
+import org.osgi.service.log.LogService;
 import org.osgi.service.obr.RepositoryAdmin;
 import org.osgi.util.tracker.ServiceTracker;
 
@@ -44,7 +45,7 @@
             }
             catch ( Throwable t )
             {
-                // missing InstallerService class ??
+                getLog().log( LogService.LOG_WARNING, "Cannot create RepositoryAdmin service tracker", t );
                 return null;
             }
 

webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/RefreshRepoAction.java

diff --git a/webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/RefreshRepoAction.java b/webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/RefreshRepoAction.java
index 7129a96..1917b00 100644
--- a/webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/RefreshRepoAction.java
+++ b/webconsole/src/main/java/org/apache/felix/webconsole/internal/obr/RefreshRepoAction.java
@@ -23,6 +23,7 @@
 import javax.servlet.http.HttpServletResponse;
 
 import org.apache.felix.webconsole.Action;
+import org.osgi.service.log.LogService;
 import org.osgi.service.obr.Repository;
 import org.osgi.service.obr.RepositoryAdmin;
 
@@ -70,7 +71,8 @@
                 }
                 catch ( Throwable t )
                 {
-                    // don't care, just ignore
+                    getLog().log( LogService.LOG_ERROR,
+                        "RefreshRepoAction: Submitted URL " + repositoryURL + " is invalid: " + t.getMessage() );
                 }
             }
 
@@ -82,11 +84,12 @@
                     try
                     {
                         repoAdmin.removeRepository( repoURL );
+                        getLog().log( LogService.LOG_INFO, "RefreshRepoAction: Removed repository " + repositoryURL );
                     }
                     catch ( Exception e )
                     {
-                        // TODO: log.log(LogService.LOG_ERROR, "Cannot refresh
-                        // Repository " + repo.getURL());
+                         getLog().log( LogService.LOG_ERROR,
+                            "RefreshRepoAction: Failed removing repository " + repositoryURL, e );
                     }
                 }
                 else
@@ -94,11 +97,12 @@
                     try
                     {
                         repoAdmin.addRepository( repoURL );
+                        getLog().log( LogService.LOG_INFO, "RefreshRepoAction: Added repository " + repositoryURL );
                     }
                     catch ( Exception e )
                     {
-                        // TODO: log.log(LogService.LOG_ERROR, "Cannot refresh
-                        // Repository " + repo.getURL());
+                        getLog().log( LogService.LOG_ERROR,
+                            "RefreshRepoAction: Failed adding repository " + repositoryURL, e );
                     }
                 }
             }