commit 159eef8f7b4244ebb0d31bb930f6793abd6d28f9
author Pierre De Rop <pderop@apache.org> Fri Jan 15 22:10:29 2010 +0000
committer Pierre De Rop <pderop@apache.org> Fri Jan 15 22:10:29 2010 +0000
tree a6a664bbf79bc5f5c9681c375bed2d7379ea3fd7
parent c051dde426b15492ed553f86a5a132d1b0349c01

fixed bug when creating a ConfigurationDependency (the pid was not set)

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@899830 13f79535-47bb-0310-9956-ffa450edef68

dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java

diff --git a/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java b/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java
index 42e4d20..5806201 100644
--- a/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java
+++ b/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java
@@ -336,8 +336,14 @@
     {
         ConfigurationDependency cd = dm.createConfigurationDependency();
         String pid = parser.getString(DescriptorParam.pid);
+        if (pid == null) {
+            throw new IllegalArgumentException("pid attribute not provided in ConfigurationDependency declaration");
+        }
+        cd.setPid(pid);
+        
         String propagate = parser.getString(DescriptorParam.propagate, "false");
         cd.setPropagate("true".equals(propagate));
+        
         String callback = parser.getString(DescriptorParam.updated, "updated");
         cd.setCallback(callback);
         return cd;