commit 005330dd02cb54fb9dd67cee6b47d4c9490dbae9
author A. J. David Bosschaert <davidb@apache.org> Fri Jun 26 10:45:48 2015 +0000
committer A. J. David Bosschaert <davidb@apache.org> Fri Jun 26 10:45:48 2015 +0000
tree eb9fa81dc3c52b1cdc80477054eca934766190f2
parent 42e9506a37eb50867c001cd93927b36f3323f8fe

FELIX-4938 - Throw an exception when service use count overflows.


git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1687743 13f79535-47bb-0310-9956-ffa450edef68

framework/src/main/java/org/apache/felix/framework/ServiceRegistry.java

diff --git a/framework/src/main/java/org/apache/felix/framework/ServiceRegistry.java b/framework/src/main/java/org/apache/felix/framework/ServiceRegistry.java
index 6702cb8..eefdddf 100644
--- a/framework/src/main/java/org/apache/felix/framework/ServiceRegistry.java
+++ b/framework/src/main/java/org/apache/felix/framework/ServiceRegistry.java
@@ -28,7 +28,6 @@
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
 import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.atomic.AtomicReference;
 
@@ -318,11 +317,12 @@
 
                 // Increment the usage count and grab the already retrieved
                 // service object, if one exists.
-                usage.m_count.incrementAndGet();
+                checkCountOverflow(usage.m_count.incrementAndGet());
+
                 svcObj = usage.getService();
                 if ( isServiceObjects )
                 {
-                    usage.m_serviceObjectsCount.incrementAndGet();
+                    checkCountOverflow(usage.m_serviceObjectsCount.incrementAndGet());
                 }
 
                 // If we have a usage count, but no service object, then we haven't
@@ -379,6 +379,17 @@
         return (S) svcObj;
     }
 
+    private void checkCountOverflow(long c)
+    {
+        if (c == Long.MAX_VALUE)
+        {
+            throw new ServiceException(
+                    "The use count for the service overflowed.",
+                    ServiceException.UNSPECIFIED,
+                    null);
+        }
+    }
+
     public boolean ungetService(final Bundle bundle, final ServiceReference<?> ref, final Object svcObj)
     {
         final ServiceRegistrationImpl reg =
@@ -414,7 +425,7 @@
 
             // If usage count will go to zero, then unget the service
             // from the registration.
-            int count = usage.m_count.decrementAndGet();
+            long count = usage.m_count.decrementAndGet();
             try
             {
                 if (count <= 0)
@@ -668,8 +679,8 @@
         final ServiceReference<?> m_ref;
         final boolean m_prototype;
 
-        final AtomicInteger m_count = new AtomicInteger();
-        final AtomicInteger m_serviceObjectsCount = new AtomicInteger();
+        final AtomicLong m_count = new AtomicLong();
+        final AtomicLong m_serviceObjectsCount = new AtomicLong();
         final AtomicReference<ServiceHolder> m_svcHolderRef = new AtomicReference<ServiceHolder>();
 
         UsageCount(final ServiceReference<?> ref, final boolean isPrototype)