Committing vpls app unit tests and correcting some bugs.
Change-Id: Ic0931c85018148d5c57e5d01b497d49e2a19da5f
diff --git a/vpls/pom.xml b/vpls/pom.xml
index 2bd66fa..b237aa0 100644
--- a/vpls/pom.xml
+++ b/vpls/pom.xml
@@ -36,20 +36,37 @@
</properties>
<dependencies>
- <dependency>
- <groupId>org.onosproject</groupId>
- <artifactId>onos-incubator-api</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.onosproject</groupId>
- <artifactId>onos-app-routing-api</artifactId>
- <version>${project.version}</version>
- </dependency>
+ <dependency>
+ <groupId>org.onosproject</groupId>
+ <artifactId>onos-incubator-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.onosproject</groupId>
+ <artifactId>onos-app-routing-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.onosproject</groupId>
+ <artifactId>onos-api</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ <classifier>tests</classifier>
+ </dependency>
<dependency>
<groupId>org.onosproject</groupId>
<artifactId>onos-app-sdnip</artifactId>
<version>1.4.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.easymock</groupId>
+ <artifactId>easymock</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.onosproject</groupId>
+ <artifactId>onlab-junit</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</project>
diff --git a/vpls/src/main/java/org/onos/vpls/IntentInstaller.java b/vpls/src/main/java/org/onos/vpls/IntentInstaller.java
index f864502..fa8d6ce 100644
--- a/vpls/src/main/java/org/onos/vpls/IntentInstaller.java
+++ b/vpls/src/main/java/org/onos/vpls/IntentInstaller.java
@@ -11,6 +11,7 @@
import org.onosproject.net.flow.TrafficSelector;
import org.onosproject.net.flow.TrafficTreatment;
import org.onosproject.net.intent.Intent;
+import org.onosproject.net.intent.IntentService;
import org.onosproject.net.intent.Key;
import org.onosproject.net.intent.MultiPointToSinglePointIntent;
import org.onosproject.net.intent.SinglePointToMultiPointIntent;
@@ -40,15 +41,19 @@
private final ApplicationId appId;
private final IntentSynchronizer intentSynchronizer;
+ private final IntentService intentService;
/**
* Class constructor.
*
* @param appId the Application ID
- * @param intentSynchronizer the intent service
+ * @param intentService the intent service
+ * @param intentSynchronizer the intent synchronizer service
*/
- public IntentInstaller(ApplicationId appId, IntentSynchronizer intentSynchronizer) {
+ public IntentInstaller(ApplicationId appId, IntentService intentService,
+ IntentSynchronizer intentSynchronizer) {
this.appId = appId;
+ this.intentService = intentService;
this.intentSynchronizer = intentSynchronizer;
}
@@ -66,12 +71,12 @@
MacAddress>> confHostPresentCPoint) {
List<Intent> intents = new ArrayList<>();
- confHostPresentCPoint.keys()
+ confHostPresentCPoint.asMap().keySet()
.forEach(vlanId -> {
List<Pair<ConnectPoint, MacAddress>> cPoints =
confHostPresentCPoint.get(vlanId).stream().collect(Collectors.toList());
- if (!cPoints.isEmpty()) {
+ if (cPoints != null && !cPoints.isEmpty()) {
for (int i = 0; i < cPoints.size(); i++) {
ConnectPoint src = cPoints.get(i).getKey();
Set<ConnectPoint> dsts = new HashSet<>();
@@ -82,13 +87,23 @@
dsts.add(dst);
}
}
- Collection<SinglePointToMultiPointIntent> brcIntents =
- buildBrcIntents(src, dsts, vlanId);
- intents.addAll(brcIntents);
- if (mac != null) {
- Collection<MultiPointToSinglePointIntent> uniIntents =
- buildUniIntents(dsts, src, vlanId, mac);
- intents.addAll(uniIntents);
+ Key brcKey = buildKey(PREFIX_BROADCAST, src, vlanId);
+ if (intentService.getIntent(brcKey) == null) {
+ SinglePointToMultiPointIntent brcIntent =
+ buildBrcIntent(brcKey, src, dsts, vlanId);
+ intents.add(brcIntent);
+ }
+ if (mac != null && countMacInCPoints(cPoints) > 1) {
+ Key uniKey = buildKey(PREFIX_UNICAST, src, vlanId);
+ if (intentService.getIntent(uniKey) == null) {
+ MultiPointToSinglePointIntent uniIntent =
+ buildUniIntent(uniKey,
+ dsts,
+ src,
+ vlanId,
+ mac);
+ intents.add(uniIntent);
+ }
}
}
}
@@ -110,78 +125,74 @@
}
/**
- * Builds a set of Single Point to Multi Point intents.
+ * Builds a Single Point to Multi Point intent.
*
* @param src The source Connect Point
* @param dsts The destination Connect Points
- * @return Single Point to Multi Point intents generated.
+ * @return Single Point to Multi Point intent generated.
*/
- private Collection<SinglePointToMultiPointIntent> buildBrcIntents(ConnectPoint src,
- Set<ConnectPoint> dsts,
- VlanId vlanId) {
- log.debug("Building p-2-mp intent from {}", src);
+ private SinglePointToMultiPointIntent buildBrcIntent(Key key,
+ ConnectPoint src,
+ Set<ConnectPoint> dsts,
+ VlanId vlanId) {
+ log.debug("Building p2mp intent from {}", src);
- List<SinglePointToMultiPointIntent> intents = new ArrayList<>();
+ SinglePointToMultiPointIntent intent;
TrafficTreatment treatment = DefaultTrafficTreatment.emptyTreatment();
-
TrafficSelector.Builder builder = DefaultTrafficSelector.builder()
.matchEthDst(MacAddress.BROADCAST)
.matchVlanId(vlanId);
TrafficSelector selector = builder.build();
- Key key = buildKey(PREFIX_BROADCAST, src, vlanId);
-
- intents.add(SinglePointToMultiPointIntent.builder()
- .appId(appId)
- .key(key)
- .selector(selector)
- .treatment(treatment)
- .ingressPoint(src)
- .egressPoints(dsts)
- .priority(PRIORITY_OFFSET)
- .build());
- return intents;
+ intent = SinglePointToMultiPointIntent.builder()
+ .appId(appId)
+ .key(key)
+ .selector(selector)
+ .treatment(treatment)
+ .ingressPoint(src)
+ .egressPoints(dsts)
+ .priority(PRIORITY_OFFSET)
+ .build();
+ return intent;
}
/**
- * Builds a set of Multi Point to Single Point intents.
+ * Builds a Multi Point to Single Point intent.
*
* @param srcs The source Connect Points
* @param dst The destination Connect Point
- * @return Multi Point to Single Point intents generated.
+ * @return Multi Point to Single Point intent generated.
*/
- private Collection<MultiPointToSinglePointIntent> buildUniIntents(Set<ConnectPoint> srcs,
- ConnectPoint dst,
- VlanId vlanId,
- MacAddress mac) {
- log.debug("Building mp-2-p intent to {}", dst);
+ private MultiPointToSinglePointIntent buildUniIntent(Key key,
+ Set<ConnectPoint> srcs,
+ ConnectPoint dst,
+ VlanId vlanId,
+ MacAddress mac) {
+ log.debug("Building mp2p intent to {}", dst);
- List<MultiPointToSinglePointIntent> intents = new ArrayList<>();
+ MultiPointToSinglePointIntent intent;
TrafficTreatment treatment = DefaultTrafficTreatment.emptyTreatment();
-
TrafficSelector.Builder builder = DefaultTrafficSelector.builder()
.matchEthDst(mac)
.matchVlanId(vlanId);
TrafficSelector selector = builder.build();
- Key key = buildKey(PREFIX_UNICAST, dst, vlanId);
-
- intents.add(MultiPointToSinglePointIntent.builder()
- .appId(appId)
- .key(key)
- .selector(selector)
- .treatment(treatment)
- .ingressPoints(srcs)
- .egressPoint(dst)
- .priority(PRIORITY_OFFSET)
- .build());
- return intents;
+ intent = MultiPointToSinglePointIntent.builder()
+ .appId(appId)
+ .key(key)
+ .selector(selector)
+ .treatment(treatment)
+ .ingressPoints(srcs)
+ .egressPoint(dst)
+ .priority(PRIORITY_OFFSET)
+ .build();
+ return intent;
}
/**
@@ -204,10 +215,27 @@
.append(cPoint.port())
.append("-")
.append(vlanId)
-
.toString();
return Key.of(keyString, appId);
}
+ /**
+ * Counts the number of mac addresses associated to a specific list of
+ * ConnectPoint.
+ *
+ * @param cPoints List of ConnectPoints, eventually binded to the MAC of the
+ * host attached
+ * @return number of mac addresses found.
+ */
+ private int countMacInCPoints(List<Pair<ConnectPoint, MacAddress>> cPoints) {
+ int macFound = 0;
+ for (Pair<ConnectPoint, MacAddress> p : cPoints) {
+ if (p.getValue() != null) {
+ macFound++;
+ }
+ }
+ return macFound;
+ }
+
}
diff --git a/vpls/src/main/java/org/onos/vpls/Vpls.java b/vpls/src/main/java/org/onos/vpls/Vpls.java
index a22df18..b8cfebe 100644
--- a/vpls/src/main/java/org/onos/vpls/Vpls.java
+++ b/vpls/src/main/java/org/onos/vpls/Vpls.java
@@ -46,7 +46,10 @@
import java.util.Map;
import java.util.Objects;
import java.util.Set;
+import java.util.concurrent.ExecutorService;
+import static org.onlab.util.BoundedThreadPool.newSingleThreadExecutor;
+import static org.onlab.util.Tools.groupedThreads;
import static org.slf4j.LoggerFactory.getLogger;
/**
@@ -82,6 +85,8 @@
private IntentInstaller intentInstaller;
+ protected ExecutorService synchronizerExecutor =
+ newSingleThreadExecutor(groupedThreads("onos/vpls", "sync"));
private IntentSynchronizer intentSynchronizer;
private ApplicationId appId;
@@ -96,10 +101,12 @@
localControllerNode = clusterService.getLocalNode();
- intentSynchronizer = new IntentSynchronizer(appId, intentService);
+ intentSynchronizer = new IntentSynchronizer(appId, intentService, synchronizerExecutor);
intentSynchronizer.start();
- intentInstaller = new IntentInstaller(appId, intentSynchronizer);
+ intentInstaller = new IntentInstaller(appId,
+ intentService,
+ intentSynchronizer);
leadershipService.addListener(leadershipEventListener);
leadershipService.runForLeadership(appId.name());
@@ -182,7 +189,8 @@
}
private void bindMacAddr(Map.Entry<VlanId, ConnectPoint> e,
- SetMultimap<VlanId, Pair<ConnectPoint, MacAddress>> confHostPresentCPoint) {
+ SetMultimap<VlanId, Pair<ConnectPoint,
+ MacAddress>> confHostPresentCPoint) {
VlanId vlanId = e.getKey();
ConnectPoint cp = e.getValue();
Set<Host> connectedHosts = hostService.getConnectedHosts(cp);
diff --git a/vpls/src/test/java/org/onos/vpls/VplsTest.java b/vpls/src/test/java/org/onos/vpls/VplsTest.java
new file mode 100644
index 0000000..6e97e3b
--- /dev/null
+++ b/vpls/src/test/java/org/onos/vpls/VplsTest.java
@@ -0,0 +1,686 @@
+/*
+ * Copyright 2014-2015 Open Networking Laboratory
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.onos.vpls;
+
+import com.google.common.collect.Sets;
+import com.google.common.util.concurrent.MoreExecutors;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.onlab.packet.Ip4Address;
+import org.onlab.packet.IpAddress;
+import org.onlab.packet.MacAddress;
+import org.onlab.packet.VlanId;
+import org.onosproject.TestApplicationId;
+import org.onosproject.app.ApplicationService;
+import org.onosproject.cluster.ClusterService;
+import org.onosproject.cluster.ClusterServiceAdapter;
+import org.onosproject.cluster.ControllerNode;
+import org.onosproject.cluster.DefaultControllerNode;
+import org.onosproject.cluster.Leadership;
+import org.onosproject.cluster.LeadershipEvent;
+import org.onosproject.cluster.LeadershipEventListener;
+import org.onosproject.cluster.LeadershipService;
+import org.onosproject.cluster.LeadershipServiceAdapter;
+import org.onosproject.cluster.NodeId;
+import org.onosproject.core.ApplicationId;
+import org.onosproject.core.CoreService;
+import org.onosproject.core.IdGenerator;
+import org.onosproject.incubator.net.intf.Interface;
+import org.onosproject.incubator.net.intf.InterfaceService;
+import org.onosproject.net.ConnectPoint;
+import org.onosproject.net.DefaultHost;
+import org.onosproject.net.DeviceId;
+import org.onosproject.net.Host;
+import org.onosproject.net.HostId;
+import org.onosproject.net.HostLocation;
+import org.onosproject.net.PortNumber;
+import org.onosproject.net.flow.DefaultTrafficSelector;
+import org.onosproject.net.flow.DefaultTrafficTreatment;
+import org.onosproject.net.flow.TrafficSelector;
+import org.onosproject.net.flow.TrafficTreatment;
+import org.onosproject.net.host.HostEvent;
+import org.onosproject.net.host.HostListener;
+import org.onosproject.net.host.HostService;
+import org.onosproject.net.host.HostServiceAdapter;
+import org.onosproject.net.intent.Intent;
+import org.onosproject.net.intent.IntentService;
+import org.onosproject.net.intent.IntentServiceAdapter;
+import org.onosproject.net.intent.Key;
+import org.onosproject.net.intent.MultiPointToSinglePointIntent;
+import org.onosproject.net.intent.SinglePointToMultiPointIntent;
+import org.onosproject.net.provider.ProviderId;
+import org.onosproject.sdnip.IntentUtils;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.stream.Collectors;
+
+import static java.lang.String.format;
+import static org.easymock.EasyMock.createMock;
+import static org.easymock.EasyMock.expect;
+import static org.easymock.EasyMock.replay;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Tests for the {@link Vpls} class.
+ */
+public class VplsTest {
+
+ private static final int NUM_DEVICES = 7;
+
+ private static final MacAddress MAC1 = MacAddress.valueOf("00:00:00:00:00:01");
+ private static final MacAddress MAC2 = MacAddress.valueOf("00:00:00:00:00:02");
+ private static final MacAddress MAC3 = MacAddress.valueOf("00:00:00:00:00:03");
+ private static final MacAddress MAC4 = MacAddress.valueOf("00:00:00:00:00:04");
+ private static final MacAddress MAC5 = MacAddress.valueOf("00:00:00:00:00:05");
+ private static final MacAddress MAC6 = MacAddress.valueOf("00:00:00:00:00:06");
+ private static final MacAddress MAC7 = MacAddress.valueOf("00:00:00:00:00:07");
+
+ private static final Ip4Address IP1 = Ip4Address.valueOf("192.168.1.1");
+ private static final Ip4Address IP2 = Ip4Address.valueOf("192.168.1.2");
+
+ private static final PortNumber P1 = PortNumber.portNumber(1);
+
+ private static final VlanId VLAN1 = VlanId.vlanId((short) 1);
+ private static final VlanId VLAN2 = VlanId.vlanId((short) 2);
+
+ private static final int PRIORITY_OFFSET = 1000;
+ private static final String PREFIX_BROADCAST = "brc";
+ private static final String PREFIX_UNICAST = "uni";
+
+ private static final DeviceId DID1 = getDeviceId(1);
+ private static final DeviceId DID2 = getDeviceId(2);
+ private static final DeviceId DID3 = getDeviceId(3);
+ private static final DeviceId DID4 = getDeviceId(4);
+ private static final DeviceId DID5 = getDeviceId(5);
+ private static final DeviceId DID6 = getDeviceId(6);
+
+ private static final ConnectPoint C1 = new ConnectPoint(DID1, P1);
+ private static final ConnectPoint C2 = new ConnectPoint(DID2, P1);
+ private static final ConnectPoint C3 = new ConnectPoint(DID3, P1);
+ private static final ConnectPoint C4 = new ConnectPoint(DID4, P1);
+ private static final ConnectPoint C5 = new ConnectPoint(DID5, P1);
+ private static final ConnectPoint C6 = new ConnectPoint(DID6, P1);
+
+ private static final HostId HID1 = HostId.hostId(MAC1, VLAN1);
+ private static final HostId HID2 = HostId.hostId(MAC2, VLAN1);
+ private static final HostId HID3 = HostId.hostId(MAC3, VLAN1);
+ private static final HostId HID4 = HostId.hostId(MAC4, VLAN2);
+ private static final HostId HID5 = HostId.hostId(MAC5, VLAN2);
+ private static final HostId HID6 = HostId.hostId(MAC6, VLAN2);
+ private static final HostId HID7 = HostId.hostId(MAC7, VlanId.NONE);
+
+ private ApplicationService applicationService;
+ private ClusterService clusterService;
+ private CoreService coreService;
+ private HostListener hostListener;
+ private Set<Host> hostsAvailable;
+ private HostService hostService;
+ private IntentService intentService;
+ private InterfaceService interfaceService;
+ private LeadershipService leadershipService;
+ private Vpls vpls;
+
+ private static final String APP_NAME = "org.onosproject.vpls";
+ private static final ApplicationId APPID = TestApplicationId.create(APP_NAME);
+
+ private static final NodeId NID_LOCAL = new NodeId("local");
+ private static final IpAddress LOCALHOST = IpAddress.valueOf("127.0.0.1");
+ private final LeadershipEvent leadershipEvent
+ = new LeadershipEvent(LeadershipEvent.Type.LEADER_ELECTED,
+ new Leadership(APP_NAME, NID_LOCAL, 0, 0));
+
+ private static final ProviderId PID = new ProviderId("of", "foo");
+
+ @BeforeClass
+ public static void setUpClass() {
+ IdGenerator idGenerator = new TestIdGenerator();
+ Intent.bindIdGenerator(idGenerator);
+ }
+
+ @Before
+ public void setUp() throws Exception {
+ clusterService = new TestClusterService();
+
+ applicationService = createMock(ApplicationService.class);
+
+ coreService = createMock(CoreService.class);
+ expect(coreService.registerApplication(APP_NAME))
+ .andReturn(APPID);
+ replay(coreService);
+
+ hostsAvailable = Sets.newHashSet();
+ hostService = new TestHostService(hostsAvailable);
+
+ intentService = new TestIntentService();
+
+ interfaceService = createMock(InterfaceService.class);
+ addIntfConfig();
+
+ leadershipService = new TestLeadershipService();
+
+ vpls = new Vpls();
+ vpls.applicationService = applicationService;
+ vpls.clusterService = clusterService;
+ vpls.coreService = coreService;
+ vpls.hostService = hostService;
+ vpls.intentService = intentService;
+ vpls.interfaceService = interfaceService;
+ vpls.leadershipService = leadershipService;
+ vpls.synchronizerExecutor = MoreExecutors.newDirectExecutorService();
+ }
+
+ /**
+ * Creates the interface configuration. On devices 1, 2 and 3 is configured
+ * an interface on port 1 with vlan 1. On devices 4, 5 and 6 is configured
+ * an interface on port 1 with vlan 2. On device 5 no interfaces are
+ * configured.
+ */
+ private void addIntfConfig() {
+ Set<Interface> interfaces = Sets.newHashSet();
+ Set<Interface> vlanOneSet = new HashSet<>();
+ Set<Interface> vlanTwoSet = new HashSet<>();
+
+ for (int i = 1; i <= NUM_DEVICES - 1; i++) {
+ ConnectPoint cp = new ConnectPoint(getDeviceId(i), P1);
+
+ Interface intf =
+ new Interface(cp, Collections.emptySet(), null, VlanId.NONE);
+
+ if (i <= 3) {
+ intf = new Interface(cp, Collections.emptySet(), null, VLAN1);
+ interfaces.add(intf);
+ vlanOneSet.add(intf);
+ } else if (i > 3 && i <= 6) {
+ intf = new Interface(cp, Collections.emptySet(), null, VLAN2);
+ interfaces.add(intf);
+ vlanTwoSet.add(intf);
+ }
+ expect(interfaceService.getInterfacesByPort(cp))
+ .andReturn(Sets.newHashSet(intf)).anyTimes();
+ }
+ expect(interfaceService.getInterfacesByVlan(VLAN1))
+ .andReturn(vlanOneSet).anyTimes();
+ expect(interfaceService.getInterfacesByVlan(VLAN2))
+ .andReturn(vlanTwoSet).anyTimes();
+ expect(interfaceService.getInterfaces()).andReturn(interfaces).anyTimes();
+
+ replay(interfaceService);
+ }
+
+ /**
+ * Checks the case in which six ports are configured with VLANs but no
+ * hosts are registered by the HostService. The first three ports have an
+ * interface configured on VLAN1, the other three on VLAN2. The number of
+ * intents expected is six: three for VLAN1, three for VLAN2. three sp2mp
+ * intents, three mp2sp intents.
+ */
+ @Test
+ public void testActivateNoHosts() {
+ vpls.activate();
+
+ List<Intent> expectedIntents = new ArrayList<>();
+ expectedIntents.addAll(generateVlanOneBrc());
+ expectedIntents.addAll(generateVlanTwoBrc());
+
+ checkIntents(expectedIntents);
+ }
+
+ /**
+ * Checks the case in which six ports are configured with VLANs and four
+ * hosts are registered by the HostService. The first three ports have an
+ * interface configured on VLAN1, the other three on VLAN2. The number of
+ * intents expected is twelve: six for VLAN1, six for VLAN2. six sp2mp
+ * intents, six mp2sp intents. For VLAN1 IPs are added to demonstrate it
+ * doesn't influence the number of intents created.
+ */
+ @Test
+ public void testFourInterfacesConfiguredHostsPresent() {
+ Host h1 = new DefaultHost(PID, HID1, MAC1, VLAN1, getLocation(1),
+ Collections.singleton(IP1));
+ Host h2 = new DefaultHost(PID, HID2, MAC2, VLAN1, getLocation(2),
+ Collections.singleton(IP2));
+ Host h3 = new DefaultHost(PID, HID3, MAC3, VLAN1, getLocation(3),
+ Collections.EMPTY_SET);
+ Host h4 = new DefaultHost(PID, HID4, MAC4, VLAN2, getLocation(4),
+ Collections.EMPTY_SET);
+ Host h5 = new DefaultHost(PID, HID5, MAC5, VLAN2, getLocation(5),
+ Collections.EMPTY_SET);
+ Host h6 = new DefaultHost(PID, HID6, MAC6, VLAN2, getLocation(6),
+ Collections.EMPTY_SET);
+ hostsAvailable.addAll(Sets.newHashSet(h1, h2, h3, h4, h5, h6));
+
+ vpls.activate();
+
+ List<Intent> expectedIntents = new ArrayList<>();
+ expectedIntents.addAll(generateVlanOneBrc());
+ expectedIntents.addAll(generateVlanOneUni());
+ expectedIntents.addAll(generateVlanTwoBrc());
+ expectedIntents.addAll(generateVlanTwoUni());
+
+ checkIntents(expectedIntents);
+ }
+
+ /**
+ * Checks the case in which six ports are configured with VLANs and
+ * initially no hosts are registered by the HostService. The first three
+ * ports have an interface configured on VLAN1, the other three have an
+ * interface configured on VLAN2. When the module starts up, three hosts -
+ * on device one, two and three - port 1 (both on VLAN1), are registered by
+ * the HostService and events are sent to the application. sp2mp intents
+ * are created for all interfaces configured and mp2sp intents are created
+ * only for the hosts attached.
+ * The number of intents expected is nine: six for VLAN1, three for VLAN2.
+ * Six sp2mp intents, three mp2sp intents. IPs are added on the first two
+ * hosts only to demonstrate it doesn't influence the number of intents
+ * created.
+ * An additional host is added on device seven, port one to demonstrate
+ * that, even if it's on the same VLAN of other interfaces configured in
+ * the system, it doesn't let the application generate intents, since it's
+ * not connected to the interface configured.
+ */
+ @Test
+ public void testFourInterfacesThreeHostEventsSameVlan() {
+ vpls.activate();
+
+ Host h1 = new DefaultHost(PID, HID1, MAC1, VLAN1, getLocation(1),
+ Collections.singleton(IP1));
+ Host h2 = new DefaultHost(PID, HID2, MAC2, VLAN1, getLocation(2),
+ Collections.singleton(IP2));
+ Host h3 = new DefaultHost(PID, HID3, MAC3, VLAN1, getLocation(3),
+ Collections.EMPTY_SET);
+ Host h7 = new DefaultHost(PID, HID7, MAC7, VLAN1, getLocation(7),
+ Collections.EMPTY_SET);
+ hostsAvailable.addAll(Sets.newHashSet(h1, h2, h3, h7));
+
+ hostsAvailable.forEach(host -> {
+ hostListener.event(new HostEvent(HostEvent.Type.HOST_ADDED, host));
+ });
+
+ List<Intent> expectedIntents = new ArrayList<>();
+ expectedIntents.addAll(generateVlanOneBrc());
+ expectedIntents.addAll(generateVlanOneUni());
+ expectedIntents.addAll(generateVlanTwoBrc());
+
+ checkIntents(expectedIntents);
+ }
+
+ /**
+ * Checks the case in which six ports are configured with VLANs and
+ * initially no hosts are registered by the HostService. The first three
+ * ports have an interface configured on VLAN1, the other three have an
+ * interface configured on VLAN2. When the module starts up, two hosts -
+ * on device one and four - port 1 (VLAN 1 and VLAN 2), are registered by
+ * the HostService and events are sent to the application. sp2mp intents
+ * are created for all interfaces configured and no mp2sp intents are created
+ * at all, since the minimum number of hosts needed on the same vlan to
+ * create mp2sp intents is 2.
+ * The number of intents expected is six: three for VLAN1, three for VLAN2.
+ * six sp2mp intents, zero mp2sp intents. IPs are added on the first host
+ * only to demonstrate it doesn't influence the number of intents created.
+ */
+ @Test
+ public void testFourInterfacesTwoHostEventsDifferentVlan() {
+ vpls.activate();
+
+ Host h1 = new DefaultHost(PID, HID1, MAC1, VLAN1, getLocation(1),
+ Collections.singleton(IP1));
+ Host h4 = new DefaultHost(PID, HID4, MAC4, VLAN2, getLocation(4),
+ Collections.EMPTY_SET);
+ hostsAvailable.addAll(Sets.newHashSet(h1, h4));
+
+ hostsAvailable.forEach(host -> {
+ hostListener.event(new HostEvent(HostEvent.Type.HOST_ADDED, host));
+ });
+
+ List<Intent> expectedIntents = new ArrayList<>();
+ expectedIntents.addAll(generateVlanOneBrc());
+ expectedIntents.addAll(generateVlanTwoBrc());
+
+ checkIntents(expectedIntents);
+ }
+
+ /**
+ * Checks both that the number of intents in submitted in the intent
+ * framework it's equal to the number of intents expected and that all
+ * intents are equivalent.
+ *
+ * @param intents the list of intents expected
+ */
+ private void checkIntents(List<Intent> intents) {
+ assertEquals(intents.size(), intentService.getIntentCount());
+
+ for (Intent intentOne : intents) {
+ boolean found = false;
+ for (Intent intentTwo : intentService.getIntents()) {
+ if (intentOne.key().equals(intentTwo.key())) {
+ found = true;
+ assertTrue(format("Comparing %s and %s", intentOne, intentTwo),
+ IntentUtils.equals(intentOne, intentTwo));
+ break;
+ }
+ }
+ assertTrue(found);
+ }
+ }
+
+ /**
+ * Generates the list of the expected sp2mp intents for VLAN 1.
+ *
+ * @return the list of expected sp2mp intents for VLAN 1
+ */
+ private List<SinglePointToMultiPointIntent> generateVlanOneBrc() {
+ Key key = null;
+
+ List<SinglePointToMultiPointIntent> intents = new ArrayList<>();
+
+ // Building sp2mp intent for H1 - VLAN1
+ key = Key.of((PREFIX_BROADCAST + "-" + DID1 + "-" + P1 + "-" + VLAN1),
+ APPID);
+ intents.add(buildBrcIntent(key, C1, Sets.newHashSet(C2, C3), VLAN1));
+
+ // Building sp2mp intent for H2 - VLAN1
+ key = Key.of((PREFIX_BROADCAST + "-" + DID2 + "-" + P1 + "-" + VLAN1),
+ APPID);
+ intents.add(buildBrcIntent(key, C2, Sets.newHashSet(C1, C3), VLAN1));
+
+ // Building sp2mp intent for H3 - VLAN1
+ key = Key.of((PREFIX_BROADCAST + "-" + DID3 + "-" + P1 + "-" + VLAN1),
+ APPID);
+ intents.add(buildBrcIntent(key, C3, Sets.newHashSet(C1, C2), VLAN1));
+
+ return intents;
+ }
+
+ /**
+ * Generates the list of the expected mp2sp intents for VLAN 1.
+ *
+ * @return the list of expected mp2sp intents for VLAN 1
+ */
+ private List<MultiPointToSinglePointIntent> generateVlanOneUni() {
+ Key key = null;
+
+ List<MultiPointToSinglePointIntent> intents = new ArrayList<>();
+
+ // Building mp2sp intent for H1 - VLAN1
+ key = Key.of((PREFIX_UNICAST + "-" + DID1 + "-" + P1 + "-" + VLAN1),
+ APPID);
+ intents.add(buildUniIntent(key, Sets.newHashSet(C2, C3), C1, VLAN1, MAC1));
+
+ // Building mp2sp intent for H2 - VLAN1
+ key = Key.of((PREFIX_UNICAST + "-" + DID2 + "-" + P1 + "-" + VLAN1),
+ APPID);
+ intents.add(buildUniIntent(key, Sets.newHashSet(C1, C3), C2, VLAN1, MAC2));
+
+ // Building mp2sp intent for H3 - VLAN1
+ key = Key.of((PREFIX_UNICAST + "-" + DID3 + "-" + P1 + "-" + VLAN1),
+ APPID);
+ intents.add(buildUniIntent(key, Sets.newHashSet(C1, C2), C3, VLAN1, MAC3));
+
+ return intents;
+ }
+
+ /**
+ * Generates the list of the expected sp2mp intents for VLAN 2.
+ *
+ * @return the list of expected sp2mp intents for VLAN 2
+ */
+ private List<SinglePointToMultiPointIntent> generateVlanTwoBrc() {
+ Key key = null;
+
+ List<SinglePointToMultiPointIntent> intents = new ArrayList<>();
+
+ // Building sp2mp intent for H4 - VLAN2
+ key = Key.of((PREFIX_BROADCAST + "-" + DID4 + "-" + P1 + "-" + VLAN2),
+ APPID);
+ intents.add(buildBrcIntent(key, C4, Sets.newHashSet(C5, C6), VLAN2));
+
+ // Building sp2mp intent for H5 - VLAN2
+ key = Key.of((PREFIX_BROADCAST + "-" + DID5 + "-" + P1 + "-" + VLAN2),
+ APPID);
+ intents.add(buildBrcIntent(key, C5, Sets.newHashSet(C4, C6), VLAN2));
+
+ // Building sp2mp intent for H6 - VLAN2
+ key = Key.of((PREFIX_BROADCAST + "-" + DID6 + "-" + P1 + "-" + VLAN2),
+ APPID);
+ intents.add(buildBrcIntent(key, C6, Sets.newHashSet(C4, C5), VLAN2));
+
+ return intents;
+ }
+
+ /**
+ * Generates the list of the expected mp2sp intents for VLAN 2.
+ *
+ * @return the list of expected mp2sp intents for VLAN 2
+ */
+ private List<MultiPointToSinglePointIntent> generateVlanTwoUni() {
+ Key key = null;
+
+ List<MultiPointToSinglePointIntent> intents = new ArrayList<>();
+
+ // Building mp2sp intent for H4 - VLAN2
+ key = Key.of((PREFIX_UNICAST + "-" + DID4 + "-" + P1 + "-" + VLAN2),
+ APPID);
+ intents.add(buildUniIntent(key, Sets.newHashSet(C5, C6), C4, VLAN2, MAC4));
+
+ // Building mp2sp intent for H5 - VLAN2
+ key = Key.of((PREFIX_UNICAST + "-" + DID5 + "-" + P1 + "-" + VLAN2),
+ APPID);
+ intents.add(buildUniIntent(key, Sets.newHashSet(C4, C6), C5, VLAN2, MAC5));
+
+ // Building mp2sp intent for H6 - VLAN2
+ key = Key.of((PREFIX_UNICAST + "-" + DID6 + "-" + P1 + "-" + VLAN2),
+ APPID);
+ intents.add(buildUniIntent(key, Sets.newHashSet(C4, C5), C6, VLAN2, MAC6));
+
+ return intents;
+ }
+
+ /**
+ * Builds a Single Point to Multi Point intent.
+ *
+ * @param key The intent key
+ * @param src The source Connect Point
+ * @param dsts The destination Connect Points
+ * @return Single Point to Multi Point intent generated.
+ */
+ private SinglePointToMultiPointIntent buildBrcIntent(Key key,
+ ConnectPoint src,
+ Set<ConnectPoint> dsts,
+ VlanId vlanId) {
+ SinglePointToMultiPointIntent intent;
+
+ TrafficTreatment treatment = DefaultTrafficTreatment.emptyTreatment();
+
+ TrafficSelector selector = DefaultTrafficSelector.builder()
+ .matchEthDst(MacAddress.BROADCAST)
+ .matchVlanId(vlanId)
+ .build();
+
+ intent = SinglePointToMultiPointIntent.builder()
+ .appId(APPID)
+ .key(key)
+ .selector(selector)
+ .treatment(treatment)
+ .ingressPoint(src)
+ .egressPoints(dsts)
+ .priority(PRIORITY_OFFSET)
+ .build();
+ return intent;
+ }
+
+ /**
+ * Builds a Multi Point to Single Point intent.
+ *
+ * @param key The intent key
+ * @param srcs The source Connect Points
+ * @param dst The destination Connect Point
+ * @return Multi Point to Single Point intent generated.
+ */
+ private MultiPointToSinglePointIntent buildUniIntent(Key key,
+ Set<ConnectPoint> srcs,
+ ConnectPoint dst,
+ VlanId vlanId,
+ MacAddress mac) {
+ MultiPointToSinglePointIntent intent;
+
+ TrafficTreatment treatment = DefaultTrafficTreatment.emptyTreatment();
+
+ TrafficSelector.Builder builder = DefaultTrafficSelector.builder()
+ .matchEthDst(mac)
+ .matchVlanId(vlanId);
+
+ TrafficSelector selector = builder.build();
+
+ intent = MultiPointToSinglePointIntent.builder()
+ .appId(APPID)
+ .key(key)
+ .selector(selector)
+ .treatment(treatment)
+ .ingressPoints(srcs)
+ .egressPoint(dst)
+ .priority(PRIORITY_OFFSET)
+ .build();
+ return intent;
+ }
+
+ /**
+ * Returns the device ID of the ith device.
+ *
+ * @param i device to get the ID of
+ * @return the device ID
+ */
+ private static DeviceId getDeviceId(int i) {
+ return DeviceId.deviceId("" + i);
+ }
+
+ private static HostLocation getLocation(int i) {
+ return new HostLocation(new ConnectPoint(getDeviceId(i), P1), 123L);
+ }
+
+ private final class TestClusterService extends ClusterServiceAdapter {
+
+ ControllerNode local = new DefaultControllerNode(NID_LOCAL, LOCALHOST);
+
+ @Override
+ public ControllerNode getLocalNode() {
+ return local;
+ }
+
+ @Override
+ public Set<ControllerNode> getNodes() {
+ return Sets.newHashSet();
+ }
+
+ }
+
+ /**
+ * LeadershipService that allows us to grab a reference to
+ * PartitionManager's LeadershipEventListener.
+ */
+ public class TestLeadershipService extends LeadershipServiceAdapter {
+
+ // Assume by default that the listener is the leader.
+ @Override
+ public void addListener(LeadershipEventListener listener) {
+ listener.event(leadershipEvent);
+ }
+
+ }
+
+ /**
+ * Represents a fake IntentService class that easily allows to store and
+ * retrieve intents without implementing the IntentService logic.
+ */
+ private class TestIntentService extends IntentServiceAdapter {
+
+ private Set<Intent> intents;
+
+ public TestIntentService() {
+ intents = Sets.newHashSet();
+ }
+
+ @Override
+ public void submit(Intent intent) {
+ intents.add(intent);
+ }
+
+ @Override
+ public long getIntentCount() {
+ return intents.size();
+ }
+
+ @Override
+ public Iterable<Intent> getIntents() {
+ return intents;
+ }
+
+ @Override
+ public Intent getIntent(Key intentKey) {
+ for (Intent intent : intents) {
+ if (intent.key().equals(intentKey)) {
+ return intent;
+ }
+ }
+ return null;
+ }
+ }
+
+ /**
+ * Represents a fake HostService class which allows to add hosts manually
+ * in each test, when needed.
+ */
+ private class TestHostService extends HostServiceAdapter {
+
+ private Set<Host> hosts;
+
+ public TestHostService(Set<Host> hosts) {
+ this.hosts = hosts;
+ }
+
+ @Override
+ public void addListener(HostListener listener) {
+ VplsTest.this.hostListener = listener;
+ }
+
+ @Override
+ public Set<Host> getConnectedHosts(ConnectPoint connectPoint) {
+ return hosts.stream()
+ .filter(h -> h.location().elementId().equals(connectPoint.elementId())
+ && h.location().port().equals(connectPoint.port()))
+ .collect(Collectors.toSet());
+ }
+
+ }
+
+ private static class TestIdGenerator implements IdGenerator {
+
+ private final AtomicLong id = new AtomicLong(0);
+
+ @Override
+ public long getNewId() {
+ return id.getAndIncrement();
+ }
+
+ }
+
+}